test(discover): add unit tests for TableCell and TableHeaderColumn#12261
Open
amarkdotdev wants to merge 1 commit into
Open
test(discover): add unit tests for TableCell and TableHeaderColumn#12261amarkdotdev wants to merge 1 commit into
amarkdotdev wants to merge 1 commit into
Conversation
amarkdotdev
requested review from
AMoo-Miki,
LDrago27,
Maosaic,
Qxisylolo,
SuZhou-Joe,
TackAdam,
ZilongX,
abbyhu2000,
ananzh,
angle943,
ashwin-pc,
bandinib-amzn,
d-buckner,
huyaboo,
joshuali925,
kavilla,
mengweieric,
paulstn,
ps48,
ruanyl,
ruchidh,
sejli,
sumukhswamy,
virajsanghvi,
wanglam,
xinruiba,
yubonluo,
zengyan-amazon,
zhongnansu and
zhyuanqi
as code owners
amarkdotdev
force-pushed
the
test/discover-table-coverage
branch
2 times, most recently
from
92c46c6 to
52f2d0a
Compare
Add comprehensive unit tests for the two untested components in the default_discover_table directory: - table_cell.test.tsx: Tests rendering of sanitized content, filter button interactions (filter-for and filter-out), time field vs non-time field styling (eui-textNoWrap vs eui-textBreakAll), and truncate-by-height wrapper behavior. - table_header_column.test.tsx: Tests column name rendering, sort button visibility and cycling (unsorted -> asc -> desc -> unsorted or back to asc when only sort), remove/move-left/move-right button rendering and callbacks, and conditional button visibility based on props (colLeftIdx, colRightIdx, isSortable, isRemoveable). Resolves opensearch-project#7048 Signed-off-by: Aaron Mark <64331623+amarkdotdev@users.noreply.github.com>
amarkdotdev
force-pushed
the
test/discover-table-coverage
branch
from
52f2d0a to
219b799
Compare
Author
|
Looked into the Code-Diff-Analyzer failure — it's not caused by the test changes in this PR. The job fails at "Set up job" because the workflow references unpinned action versions (
This appears to be an upstream workflow configuration issue. Retriggered CI with |
amarkdotdev
force-pushed
the
test/discover-table-coverage
branch
2 times, most recently
from
b8fa2a1 to
219b799
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds unit tests for two previously untested components in
src/plugins/discover/public/application/components/default_discover_table/.table_cell.test.tsx (8 tests)
eui-textNoWrap) vs non-time field styling (eui-textBreakAll)table_header_column.test.tsx (12 tests)
isSortableproponRemoveColumnTesting
Resolves #7048